missing lemmas about ereal#1264
Merged
affeldt-aist merged 9 commits intomath-comp:masterfrom Jul 25, 2024
Merged
Conversation
affeldt-aist
added
the
enhancement ✨
proux01
reviewed
Jul 23, 2024
Collaborator
proux01
left a comment
proux01
left a comment
There was a problem hiding this comment.
We need the dual addition versions but otherwise looks good to me.
Member
Author
|
The dual lemmas have not been updated to the new naming scheme (my fault). |
Collaborator
|
I agree the latter is more readable. |
Member
Author
|
Then I'll do the renaming along this PR. |
Collaborator
|
Thanks a lot! |
Member
Author
|
Lemmas in the dual version should be aligned. |
proux01
approved these changes
Jul 24, 2024
Collaborator
proux01
left a comment
proux01
left a comment
There was a problem hiding this comment.
A few details but otherwise LGTM
Co-authored-by: Pierre Roux <pierre.roux@onera.fr>
Co-authored-by: Pierre Roux <pierre.roux@onera.fr>
Co-authored-by: Pierre Roux <pierre.roux@onera.fr>
Co-authored-by: Pierre Roux <pierre.roux@onera.fr>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation for this change
just noticed a missing lemma in
constructive_ereal.vthat helps shorten a proofChecklist
CHANGELOG_UNRELEASED.md- [ ] added corresponding documentation in the headersReference: How to document
Reminder to reviewers